linux-kernel - Re: [PATCH] staging : android : fix checkpatch issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 9 Feb 2014 20:26:46 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Daeseok Youn <daeseok.youn@...il.com>
Cc:	john.stultz@...aro.org, ohaugan@...eaurora.org, romlem@...gle.com,
	devel@...verdev.osuosl.org, konkers@...roid.com,
	linux-kernel@...r.kernel.org, ccross@...roid.com,
	rebecca@...roid.com, prtvar.b@...il.com
Subject: Re: [PATCH] staging : android : fix checkpatch issues

On Mon, Feb 10, 2014 at 10:59:14AM +0900, Daeseok Youn wrote:
> >From 1348300b03697d0499eddba6035a851d1278abd1 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn@...il.com>
> Date: Mon, 10 Feb 2014 10:45:30 +0900
> Subject: [PATCH] staging : android : fix checkpatch issues
> 
> drivers/staging/android/
> ion/ion.c :
>  - WARNNING: Unnecessary space after function pointer name
>  - ERROR: return is not a function, parentheses are not required
>  - WARNNING: Prefer seq_puts to seq_printf
>  - WARNING: quoted string split across lines
> 
> ion/ion_priv.h :
>  - WARNING: Unnecessary space after function pointer name
> 
> sync.h :
>  - WARNING: missing space after return type
> 
> timed_output.h :
>  - WARNING: Multiple spaces after return type

You are doing multiple things in different files, please break this up
into smaller patches...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/