linux-kernel - Re: [PATCH] staging : android : fix checkpatch issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHb8M2BVk6z+JSu6-hG7B_qRdFdBdvSGdwNU1BQRAJjv7x0dvA@mail.gmail.com>
Date:	Mon, 10 Feb 2014 20:10:55 +0900
From:	DaeSeok Youn <daeseok.youn@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	John Stultz <john.stultz@...aro.org>, ohaugan@...eaurora.org,
	Rom Lemarchand <romlem@...gle.com>,
	devel <devel@...verdev.osuosl.org>,
	konkers <konkers@...roid.com>,
	linux-kernel <linux-kernel@...r.kernel.org>, ccross@...roid.com,
	Rebecca Zavin <rebecca@...roid.com>, prtvar.b@...il.com
Subject: Re: [PATCH] staging : android : fix checkpatch issues

OK. I will re-send this patch except replacing seq_printf() with seq_puts().
Your review helped me a lot.

Thanks.
Daeseok Youn.


2014-02-10 19:52 GMT+09:00 Dan Carpenter <dan.carpenter@...cle.com>:
> On Mon, Feb 10, 2014 at 07:23:46PM +0900, DaeSeok Youn wrote:
>> Thanks for reviewing.
>>
>> Yes, I just followed by reports of checkpatch.pl.
>>
>> But I don't understand why I can use of seq_puts() in the middle of
>> seq_printf() calls.
>> I have been trying to search why that is not good but I didn't find
>> anything about that.
>> And I saw patches which were already merged similar with this patch.
>>
>> You can see with this url
>> https://github.com/torvalds/linux/commit/2d219c518882d2b2bac77742a6a8979c9dad051a
>> https://github.com/mirrors/linux-2.6/commit/7aff38176e79a22b1749c2af74060028298e6a45
>>
>> If you don't mind, let me know why it is not good.
>
> Because it doesn't look nice.  It messes up the alignment.
>
> Checkpatch is a tool not a king of the world.  Stop obeying checkpatch.
>
> regards,
> dan carpenter
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/