linux-kernel - Re: [PATCH 10/21] fs: Mark functions as static in gfs2/rgrp.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Feb 2014 12:30:20 +0000
From:	Steven Whitehouse <swhiteho@...hat.com>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org, cluster-devel@...hat.com,
	josh@...htriplett.org
Subject: Re: [PATCH 10/21] fs: Mark functions as static in gfs2/rgrp.c

Hi,

On Sun, 2014-02-09 at 18:40 +0530, Rashika Kheria wrote:
> Mark functions as static in gfs2/rgrp.c because they are not used
> outside this file.
> 
> This eliminates the following warning in gfs2/rgrp.c:
> fs/gfs2/rgrp.c:1092:5: warning: no previous prototype for ‘gfs2_rgrp_bh_get’ [-Wmissing-prototypes]
> fs/gfs2/rgrp.c:1157:5: warning: no previous prototype for ‘update_rgrp_lvb’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>
> ---
>  fs/gfs2/rgrp.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Now in the GFS2 -nmw tree. Thanks,

Steve.

> diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
> index a1da213..551b9e9 100644
> --- a/fs/gfs2/rgrp.c
> +++ b/fs/gfs2/rgrp.c
> @@ -1102,7 +1102,7 @@ static u32 count_unlinked(struct gfs2_rgrpd *rgd)
>   * Returns: errno
>   */
>  
> -int gfs2_rgrp_bh_get(struct gfs2_rgrpd *rgd)
> +static int gfs2_rgrp_bh_get(struct gfs2_rgrpd *rgd)
>  {
>  	struct gfs2_sbd *sdp = rgd->rd_sbd;
>  	struct gfs2_glock *gl = rgd->rd_gl;
> @@ -1169,7 +1169,7 @@ fail:
>  	return error;
>  }
>  
> -int update_rgrp_lvb(struct gfs2_rgrpd *rgd)
> +static int update_rgrp_lvb(struct gfs2_rgrpd *rgd)
>  {
>  	u32 rl_flags;
>  


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/