linux-kernel - Re: [PATCH 07/21] fs: Mark function as static in ext2/xattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140211204847.GC22835@quack.suse.cz>
Date:	Tue, 11 Feb 2014 21:48:47 +0100
From:	Jan Kara <jack@...e.cz>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org, Jan Kara <jack@...e.cz>,
	linux-ext4@...r.kernel.org, josh@...htriplett.org
Subject: Re: [PATCH 07/21] fs: Mark function as static in
 ext2/xattr_security.c

On Sun 09-02-14 18:34:10, Rashika Kheria wrote:
> Mark function as static in ext2/xattr_security.c because it is not
> used outside this file.
> 
> This also elimiantes the following warning in ext2/xattr_security.c:
> fs/ext2/xattr_security.c:45:5: warning: no previous prototype for ‘ext2_initxattrs’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>
  Thanks. I've merged the patch.

								Honza
> ---
>  fs/ext2/xattr_security.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext2/xattr_security.c b/fs/ext2/xattr_security.c
> index cfedb2c..c0ebc4d 100644
> --- a/fs/ext2/xattr_security.c
> +++ b/fs/ext2/xattr_security.c
> @@ -42,8 +42,8 @@ ext2_xattr_security_set(struct dentry *dentry, const char *name,
>  			      value, size, flags);
>  }
>  
> -int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> -		    void *fs_info)
> +static int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> +			   void *fs_info)
>  {
>  	const struct xattr *xattr;
>  	int err = 0;
> -- 
> 1.7.9.5
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/