linux-kernel - drm/msm: CONFIG_MSM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1392133181.3755.14.camel@x220>
Date:	Tue, 11 Feb 2014 16:39:41 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Rob Clark <robdclark@...il.com>
Cc:	Richard Weinberger <richard@....at>,
	David Airlie <airlied@...ux.ie>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: drm/msm:  CONFIG_MSM_OCMEM?

Rob,

Commit 55459968176f ("drm/msm: add a330/apq8x74") added preprocessor
checks for CONFIG_MSM_OCMEM. But I couldn't find a Kconfig symbol
MSM_OCMEM (nor a preprocessor define for a macro of that name). Why were
those preprocessor checks added?

Please note that lines 197-201 currently read:
    /* Set the OCMEM base address for A330, etc */
    if (a3xx_gpu->ocmem_hdl) {
            gpu_write(gpu, REG_A3XX_RB_GMEM_BASE_ADDR,
                    (unsigned int)(a3xx_gpu->ocmem_base >> 14));
    }

ocmem_hdl and ocmem_base are used uninitialized here, aren't they? So it
seems these lines should be wrapped with a preprocessor check for
CONFIG_MSM_OCMEM too.

Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/