lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Feb 2014 12:29:49 -0500 From: Rob Clark <robdclark@...il.com> To: Paul Bolle <pebolle@...cali.nl> Cc: Richard Weinberger <richard@....at>, David Airlie <airlied@...ux.ie>, "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-arm-msm@...r.kernel.org Subject: Re: drm/msm: CONFIG_MSM_OCMEM? On Tue, Feb 11, 2014 at 10:39 AM, Paul Bolle <pebolle@...cali.nl> wrote: > Rob, > > Commit 55459968176f ("drm/msm: add a330/apq8x74") added preprocessor > checks for CONFIG_MSM_OCMEM. But I couldn't find a Kconfig symbol > MSM_OCMEM (nor a preprocessor define for a macro of that name). Why were > those preprocessor checks added? At the moment, CONFIG_MSM_OCMEM is only in downstream kernel.. not 100% sure about how we'll handle that upstream when there is more than just drm/msm using OCMEM (which can be shared between gpu, video enc/dec, etc). > Please note that lines 197-201 currently read: > /* Set the OCMEM base address for A330, etc */ > if (a3xx_gpu->ocmem_hdl) { > gpu_write(gpu, REG_A3XX_RB_GMEM_BASE_ADDR, > (unsigned int)(a3xx_gpu->ocmem_base >> 14)); > } > > ocmem_hdl and ocmem_base are used uninitialized here, aren't they? So it > seems these lines should be wrapped with a preprocessor check for > CONFIG_MSM_OCMEM too. in this case ocmem_hdl will be NULL (since a3xx_gpu is kzalloc'd). The #ifdef's could be added here, but not required. BR, -R > > Paul Bolle > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists