linux-kernel - Re: [PATCH 5/9] rcu: Use MAX_NICE to replace hard coding of 19.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140211161313.GV4250@linux.vnet.ibm.com>
Date:	Tue, 11 Feb 2014 08:13:13 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Josh Triplett <josh@...edesktop.org>
Cc:	Dongsheng Yang <yangds.fnst@...fujitsu.com>,
	linux-kernel@...r.kernel.org,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH 5/9] rcu: Use MAX_NICE to replace hard coding of 19.

On Tue, Feb 11, 2014 at 07:37:32AM -0800, Josh Triplett wrote:
> On Tue, Feb 11, 2014 at 03:34:49PM +0800, Dongsheng Yang wrote:
> > Signed-off-by: Dongsheng Yang <yangds.fnst@...fujitsu.com>
> > cc: Josh Triplett <josh@...edesktop.org>
> > cc: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
> > cc: Peter Zijlstra <peterz@...radead.org>
> > cc: Ingo Molnar <mingo@...nel.org>
> 
> Reviewed-by: Josh Triplett <josh@...htriplett.org>

I get complaints about MAX_NICE being undefined, and I don't see any
definition of MAX_NICE in sched.h as of 3.14-rc2.  Am I looking in
the wrong place, or is this symbol not yet quite in mainline?

						Thanx, Paul

> >  kernel/rcu/torture.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/kernel/rcu/torture.c b/kernel/rcu/torture.c
> > index 732f8ae..219761d 100644
> > --- a/kernel/rcu/torture.c
> > +++ b/kernel/rcu/torture.c
> > @@ -805,7 +805,7 @@ rcu_torture_writer(void *arg)
> >  	static DEFINE_RCU_RANDOM(rand);
> >  
> >  	VERBOSE_PRINTK_STRING("rcu_torture_writer task started");
> > -	set_user_nice(current, 19);
> > +	set_user_nice(current, MAX_NICE);
> >  
> >  	do {
> >  		schedule_timeout_uninterruptible(1);
> > @@ -871,7 +871,7 @@ rcu_torture_fakewriter(void *arg)
> >  	DEFINE_RCU_RANDOM(rand);
> >  
> >  	VERBOSE_PRINTK_STRING("rcu_torture_fakewriter task started");
> > -	set_user_nice(current, 19);
> > +	set_user_nice(current, MAX_NICE);
> >  
> >  	do {
> >  		schedule_timeout_uninterruptible(1 + rcu_random(&rand)%10);
> > @@ -987,7 +987,7 @@ rcu_torture_reader(void *arg)
> >  	unsigned long long ts;
> >  
> >  	VERBOSE_PRINTK_STRING("rcu_torture_reader task started");
> > -	set_user_nice(current, 19);
> > +	set_user_nice(current, MAX_NICE);
> >  	if (irqreader && cur_ops->irq_capable)
> >  		setup_timer_on_stack(&t, rcu_torture_timer, 0);
> >  
> > @@ -1584,7 +1584,7 @@ static int rcu_torture_barrier_cbs(void *arg)
> >  
> >  	init_rcu_head_on_stack(&rcu);
> >  	VERBOSE_PRINTK_STRING("rcu_torture_barrier_cbs task started");
> > -	set_user_nice(current, 19);
> > +	set_user_nice(current, MAX_NICE);
> >  	do {
> >  		wait_event(barrier_cbs_wq[myid],
> >  			   (newphase =
> > -- 
> > 1.8.2.1
> > 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/