linux-kernel - Re: [PATCH 8/9] workqueue: Replace hardcoding of -20 and 19 with MIN_NICE and MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140211175041.GH24490@htj.dyndns.org>
Date:	Tue, 11 Feb 2014 12:50:41 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Dongsheng Yang <yangds.fnst@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH 8/9] workqueue: Replace hardcoding of -20 and 19 with
 MIN_NICE and MAX_NICE.

On Tue, Feb 11, 2014 at 03:34:52PM +0800, Dongsheng Yang wrote:
> Signed-off-by: Dongsheng Yang <yangds.fnst@...fujitsu.com>
> cc: Tejun Heo <tj@...nel.org>
> cc: Peter Zijlstra <peterz@...radead.org>
> cc: Ingo Molnar <mingo@...nel.org>
> ---
>  kernel/workqueue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index 82ef9f3..e4f5905 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -3218,7 +3218,7 @@ static ssize_t wq_nice_store(struct device *dev, struct device_attribute *attr,
>  		return -ENOMEM;
>  
>  	if (sscanf(buf, "%d", &attrs->nice) == 1 &&
> -	    attrs->nice >= -20 && attrs->nice <= 19)
> +	    attrs->nice >= MIN_NICE && attrs->nice <= MAX_NICE)

No objection.  If this gets accepted, it will be routed through -tip,
I suppose?  Please feel free to add

 Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/