linux-kernel - Re: [PATCH v6] mfd: MAX6650/6651 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140212175018.GJ28112@sirena.org.uk>
Date:	Wed, 12 Feb 2014 17:50:18 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Laszlo Papp <lpapp@....org>
Cc:	lee.jones@...aro.org, linus.walleij@...aro.org,
	linux-kernel@...r.kernel.org, k.kozlowski@...sung.com,
	sachin.kamat@...aro.org, jdelvare@...e.de, linux@...ck-us.net
Subject: Re: [PATCH v6] mfd: MAX6650/6651 support

On Wed, Feb 12, 2014 at 04:02:40AM +0000, Laszlo Papp wrote:

> +const struct regmap_config max665x_regmap_config = {
> +	.reg_bits = 5,
> +};

This would normally be static too, and I'd *really* expect to see a
val_bits set here.  I'm a bit surprised this works without one.

> +	mutex_init(&max665x->iolock);

What is this needed for?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)