linux-kernel - Re: [PATCH] PCI/MSI: Fix cut-and-paste errors in documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140212191425.GA5554@google.com>
Date:	Wed, 12 Feb 2014 12:14:25 -0700
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Alexander Gordeev <agordeev@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH] PCI/MSI: Fix cut-and-paste errors in documentation

On Wed, Feb 12, 2014 at 11:35:25AM +0100, Alexander Gordeev wrote:
> Function pci_enable_msi_range() is used in examples where
> pci_enable_msix_range() should have been used instead.
> 
> Reported-by: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: linux-pci@...r.kernel.org
> Signed-off-by: Alexander Gordeev <agordeev@...hat.com>

Applied to pci/misc for v3.15, thanks!

Bjorn

> ---
>  Documentation/PCI/MSI-HOWTO.txt |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/PCI/MSI-HOWTO.txt b/Documentation/PCI/MSI-HOWTO.txt
> index a8d0100..43c5a5f 100644
> --- a/Documentation/PCI/MSI-HOWTO.txt
> +++ b/Documentation/PCI/MSI-HOWTO.txt
> @@ -257,8 +257,8 @@ possible, likely up to the limit returned by pci_msix_vec_count() function:
>  
>  static int foo_driver_enable_msix(struct foo_adapter *adapter, int nvec)
>  {
> -	return pci_enable_msi_range(adapter->pdev, adapter->msix_entries,
> -				    1, nvec);
> +	return pci_enable_msix_range(adapter->pdev, adapter->msix_entries,
> +				     1, nvec);
>  }
>  
>  Note the value of 'minvec' parameter is 1.  As 'minvec' is inclusive,
> @@ -269,8 +269,8 @@ In this case the function could look like this:
>  
>  static int foo_driver_enable_msix(struct foo_adapter *adapter, int nvec)
>  {
> -	return pci_enable_msi_range(adapter->pdev, adapter->msix_entries,
> -				    FOO_DRIVER_MINIMUM_NVEC, nvec);
> +	return pci_enable_msix_range(adapter->pdev, adapter->msix_entries,
> +				     FOO_DRIVER_MINIMUM_NVEC, nvec);
>  }
>  
>  4.3.1.2 Exact number of MSI-X interrupts
> @@ -282,8 +282,8 @@ parameters:
>  
>  static int foo_driver_enable_msix(struct foo_adapter *adapter, int nvec)
>  {
> -	return pci_enable_msi_range(adapter->pdev, adapter->msix_entries,
> -				    nvec, nvec);
> +	return pci_enable_msix_range(adapter->pdev, adapter->msix_entries,
> +				     nvec, nvec);
>  }
>  
>  4.3.1.3 Specific requirements to the number of MSI-X interrupts
> -- 
> 1.7.7.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/