linux-kernel - Re: [PATCH v6] mfd: MAX6650/6651 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140213102621.GO28112@sirena.org.uk>
Date:	Thu, 13 Feb 2014 10:26:21 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Laszlo Papp <lpapp@....org>
Cc:	Lee Jones <lee.jones@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	Jean Delvare <jdelvare@...e.de>,
	Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH v6] mfd: MAX6650/6651 support

On Thu, Feb 13, 2014 at 09:14:11AM +0000, Laszlo Papp wrote:
> On Thu, Feb 13, 2014 at 8:23 AM, Lee Jones <lee.jones@...aro.org> wrote:
> > Laszlo,
> >
> >> > +const struct regmap_config max665x_regmap_config = {
> >> > +   .reg_bits = 5,
> >> > +};

> >> This would normally be static too, and I'd *really* expect to see a
> >> val_bits set here.  I'm a bit surprised this works without one.

> > Mark (privately) mentioned to me that this patch can't possibly work
> > given the current Regmap configuration.

> Strange because I have tested the change, although not for days and
> weeks. What exactly cannot possible work?

The fact that it's using 5 bit registers should cause it to be rejected
when trying to initialise as the regmap code doesn't support 5 bit
registers, and I'd not expect us to have selected sensible value
formatting code either.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)