linux-kernel - Re: [PATCH] drivers: net: cpsw: fix buggy loop condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Feb 2014 19:44:46 +0530
From:	Mugunthan V N <mugunthanvnm@...com>
To:	Heiko Schocher <hs@...x.de>, <linux-arm-kernel@...ts.infradead.org>
CC:	"David S. Miller" <davem@...emloft.net>,
	Sebastian Siewior <bigeasy@...utronix.de>,
	Daniel Mack <zonque@...il.com>, Felipe Balbi <balbi@...com>,
	Markus Pargmann <mpa@...gutronix.de>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: net: cpsw: fix buggy loop condition

On Thursday 13 February 2014 07:17 PM, Heiko Schocher wrote:
> commit:
> From 0cd8f9cc0654c06adde353c6532114c5f53a18e8 Mon Sep 17 00:00:00 2001
> From: Mugunthan V N <mugunthanvnm@...com>
> Date: Thu, 23 Jan 2014 00:03:12 +0530
> Subject: [PATCH] drivers: net: cpsw: enable promiscuous mode support
>
> Enable promiscuous mode support for CPSW.
>
> Introduced a crash on an am335x based board (similiar to am335x-evm).
> Reason is buggy end condition in for loop in cpsw_set_promiscious()
>
> for (i = 0; i <= priv->data.slaves; i++)
>
> should be
>
> for (i = 0; i < priv->data.slaves; i++)
>
> Fix this ...
>
> Signed-off-by: Heiko Schocher <hs@...x.de>
> Cc: Mugunthan V N <mugunthanvnm@...com>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Sebastian Siewior <bigeasy@...utronix.de>
> Cc: Daniel Mack <zonque@...il.com>
> Cc: Felipe Balbi <balbi@...com>
> Cc: Markus Pargmann <mpa@...gutronix.de>
> Cc: netdev@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
Ah, it's copy paste error, thanks for the fix.

Acked-by: Mugunthan V N <mugunthanvnm@...com>

Regards
Mugunthan V N
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/