linux-kernel - Re: [PATCH] drivers: net: cpsw: fix buggy loop condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140213.185131.1052801902077727878.davem@davemloft.net>
Date:	Thu, 13 Feb 2014 18:51:31 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hs@...x.de
Cc:	linux-arm-kernel@...ts.infradead.org, mugunthanvnm@...com,
	bigeasy@...utronix.de, zonque@...il.com, balbi@...com,
	mpa@...gutronix.de, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: net: cpsw: fix buggy loop condition

From: Heiko Schocher <hs@...x.de>
Date: Thu, 13 Feb 2014 14:47:27 +0100

> commit:
> From 0cd8f9cc0654c06adde353c6532114c5f53a18e8 Mon Sep 17 00:00:00 2001
> From: Mugunthan V N <mugunthanvnm@...com>
> Date: Thu, 23 Jan 2014 00:03:12 +0530
> Subject: [PATCH] drivers: net: cpsw: enable promiscuous mode support

The correct way to reference a commit is:

$(SHA1_ID) ("Commit message header text.")

So in this case it would be:

Commit 0cd8f9cc0654c06adde353c6532114c5f53a18e8 ("drivers: net: cpsw:
enable promiscuous mode support")

I fixed this up when applying this patch.  I will not extend this same
courtesy next time.

> Enable promiscuous mode support for CPSW.
> 
> Introduced a crash on an am335x based board (similiar to am335x-evm).
> Reason is buggy end condition in for loop in cpsw_set_promiscious()
> 
> for (i = 0; i <= priv->data.slaves; i++)
> 
> should be
> 
> for (i = 0; i < priv->data.slaves; i++)
> 
> Fix this ...
> 
> Signed-off-by: Heiko Schocher <hs@...x.de>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/