linux-kernel - Re: [RFC PATCH] Fix: module signature vs tracepoints: add new TAINT_UNSIGNED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140213102817.4bfd5eac@gandalf.local.home>
Date:	Thu, 13 Feb 2014 10:28:17 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc:	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Rusty Russell <rusty@...tcorp.com.au>,
	David Howells <dhowells@...hat.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [RFC PATCH] Fix: module signature vs tracepoints: add new
 TAINT_UNSIGNED_MODULE

On Thu, 13 Feb 2014 15:10:14 +0000 (UTC)
Mathieu Desnoyers <mathieu.desnoyers@...icios.com> wrote:

> ----- Original Message -----
> > From: "Steven Rostedt" <rostedt@...dmis.org>
> > To: "Ingo Molnar" <mingo@...nel.org>
> > Cc: "Mathieu Desnoyers" <mathieu.desnoyers@...icios.com>, linux-kernel@...r.kernel.org, "Ingo Molnar"
> > <mingo@...hat.com>, "Thomas Gleixner" <tglx@...utronix.de>, "Rusty Russell" <rusty@...tcorp.com.au>, "David Howells"
> > <dhowells@...hat.com>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
> > Sent: Tuesday, February 11, 2014 11:45:34 PM
> > Subject: Re: [RFC PATCH] Fix: module signature vs tracepoints: add new TAINT_UNSIGNED_MODULE
> > 
> > 
> [...]
> > But if the kernel expects to have signed modules, and you force a
> > module to be loaded that is not signed, then you still get that
> > "forced" module taint, which is the same one as loading a module from
> > an older kernel into a newer kernel. It's a different problem, and I
> > can see having a different taint flag be more informative to kernel
> > developers in general. I would welcome that change with or without
> > letting tracepoints be set for that module.
> 
> There is one important inaccuracy in your explanation above: a
> kernel supporting signed modules, but not enforcing "sig_force",
> can load unsigned modules with a simple modprobe or insmod, without
> any "--force" argument. Therefore, tainting the module as
> "TAINT_FORCED_MODULE" is misleading.
> 

Oh! You are saying that if the kernel only *supports* signed modules,
and you load a module that is not signed, it will taint the kernel?


-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/