linux-kernel - Re: [PATCH 05/21] fs: Mark function as static in exofs/super.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMpEsFHiGFaA2t6yMT7VCyRq93wYv8uOqhg6W=xAYvGtztjr=w@mail.gmail.com>
Date:	Thu, 13 Feb 2014 23:31:08 +0530
From:	Rashika Kheria <rashika.kheria@...il.com>
To:	Boaz Harrosh <bharrosh@...asas.com>
Cc:	Linux-Kernel <linux-kernel@...r.kernel.org>,
	Benny Halevy <bhalevy@...ian.com>, osd-dev@...n-osd.org,
	Josh Triplett <josh@...htriplett.org>
Subject: Re: [PATCH 05/21] fs: Mark function as static in exofs/super.c

On Thu, Feb 13, 2014 at 11:28 PM, Boaz Harrosh <bharrosh@...asas.com> wrote:
> On 02/09/2014 03:01 PM, Rashika Kheria wrote:
>> Mark function as static in exofs/super.c because it is not used outside
>> this file.
>>
>> This also eliminates the following warning in exofs/super.c:
>> fs/exofs/super.c:546:5: warning: no previous prototype for '__alloc_dev_table' [-Wmissing-prototypes]
>>
>> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
>> Reviewed-by: Josh Triplett <josh@...htriplett.org>
>
> Hi Rashika
>
> Thanks for the fixes.
>
> Do you need me to push it to Linus through my tree or do you need an:
> ACK-by: Boaz Harrosh <bharrosh@...asas.com>
>
> [Same for [PATCH 06/21] fs: Mark functions as static in exofs/ore_raid.c ]
>
> Thanks again
> Boaz
>

Hi Boaz,

It would be nice if you could push it to Linus through you tree.

Thanks,
Rashika Kheria

>> ---
>>  fs/exofs/super.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/exofs/super.c b/fs/exofs/super.c
>> index 9d97633..57f59a2 100644
>> --- a/fs/exofs/super.c
>> +++ b/fs/exofs/super.c
>> @@ -543,8 +543,8 @@ static int exofs_devs_2_odi(struct exofs_dt_device_info *dt_dev,
>>       return !(odi->systemid_len || odi->osdname_len);
>>  }
>>
>> -int __alloc_dev_table(struct exofs_sb_info *sbi, unsigned numdevs,
>> -                   struct exofs_dev **peds)
>> +static int __alloc_dev_table(struct exofs_sb_info *sbi, unsigned numdevs,
>> +                          struct exofs_dev **peds)
>>  {
>>       struct __alloc_ore_devs_and_exofs_devs {
>>               /* Twice bigger table: See exofs_init_comps() and comment at
>>
>



-- 
Rashika Kheria
B.Tech CSE
IIIT Hyderabad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/