linux-kernel - Re: [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Feb 2014 19:02:46 +0100
From:	rauchwolke@....net
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Matthew Garrett <matthew.garrett@...ula.com>,
	"david.henningsson@...onical.com" <david.henningsson@...onical.com>,
	"ibm-acpi-devel@...ts.sourceforge.net" 
	<ibm-acpi-devel@...ts.sourceforge.net>,
	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>,
	"ibm-acpi@....eng.br" <ibm-acpi@....eng.br>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] thinkpad_acpi: Fix inconsistent mute LED after resume

Hi,

this patch doesn't work. The sound is now muted after the resume (light is on). 
But the userspace knows nothing about it. (kmix shows the volume as umuted)

Peter


On Thu, 13 Feb 2014 09:35:30 +0100
Takashi Iwai <tiwai@...e.de> wrote:

> At Wed, 12 Feb 2014 20:37:36 +0000,
> Matthew Garrett wrote:
> > 
> > On Wed, 2014-02-12 at 16:32 +0100, Takashi Iwai wrote:
> > > The mute LED states have to be restored after resume.
> > 
> > Oh, never mind, we're not doing this through the LED class, are we?
> 
> Good point.  It seems that leds_class has pm_ops but it's enabled only
> when a flag is set.
> 
> I added the original bug reporter to Cc.  (Don't know the name,
> Bugzilla shows only the email address.)
> Could you check the patch below works instead of the previous fix?
> 
> 
> Takashi
> 
> ---
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index defb6afc1409..16edf75d9c00 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -4796,6 +4796,7 @@ static struct tpacpi_led_classdev tpacpi_led_thinklight = {
>  		.name		= "tpacpi::thinklight",
>  		.brightness_set	= &light_sysfs_set,
>  		.brightness_get	= &light_sysfs_get,
> +		.flags		= LED_CORE_SUSPENDRESUME,
>  	}
>  };
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/