linux-kernel - Re: [PATCH] sparc: fix implicit include of slab.h in leon_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140213.160144.63805570344280696.davem@davemloft.net>
Date:	Thu, 13 Feb 2014 16:01:44 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	tj@...nel.org
Cc:	paul.gortmaker@...driver.com, sparclinux@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
	sfr@...b.auug.org.au
Subject: Re: [PATCH] sparc: fix implicit include of slab.h in
 leon_pci_grpci2.c

From: Tejun Heo <tj@...nel.org>
Date: Thu, 13 Feb 2014 15:42:17 -0500

> On Thu, Feb 13, 2014 at 10:59:18AM -0500, Paul Gortmaker wrote:
>> To fix:
>> 
>> arch/sparc/kernel/leon_pci_grpci2.c: In function 'grpci2_of_probe':
>> arch/sparc/kernel/leon_pci_grpci2.c:720:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
>> arch/sparc/kernel/leon_pci_grpci2.c:720:20: error: assignment makes pointer from integer without a cast [-Werror]
>> arch/sparc/kernel/leon_pci_grpci2.c:882:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
>> cc1: all warnings being treated as errors
>> make[2]: *** [arch/sparc/kernel/leon_pci_grpci2.o] Error 1
>> 
>> According to Stephen, these types of failures are caused by
>> commit 2bd59d48ebfb ("cgroup: convert to kernfs") which was
>> being included implicitly via cgroup.h's inclusion of xattr.h
>> (which has now been removed).
>> 
>> Cc: Stephen Rothwell <sfr@...b.auug.org.au>
>> Cc: Tejun Heo <tj@...nel.org>
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> 
> Darn, another one.  David, can you please ack this one?  I'll push it
> through cgroup/for-3.15 so that -next doesn't break.

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/