linux-kernel - Re: [PATCH v6] mfd: MAX6650/6651 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140214205743.GV4451@sirena.org.uk>
Date:	Fri, 14 Feb 2014 20:57:43 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Laszlo Papp <lpapp@....org>
Cc:	Lee Jones <lee.jones@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	Jean Delvare <jdelvare@...e.de>,
	Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH v6] mfd: MAX6650/6651 support

On Fri, Feb 14, 2014 at 09:02:20AM +0000, Laszlo Papp wrote:
> On Wed, Feb 12, 2014 at 5:50 PM, Mark Brown <broonie@...nel.org> wrote:
> > On Wed, Feb 12, 2014 at 04:02:40AM +0000, Laszlo Papp wrote:

> >> +const struct regmap_config max665x_regmap_config = {
> >> +     .reg_bits = 5,
> >> +};

> > This would normally be static too, and I'd *really* expect to see a
> > val_bits set here.  I'm a bit surprised this works without one.

> Makes sense, thanks. Shall I also set the .max_register or any other
> mandatory variables in here?

It's better to set max_register since that makes the debug features of
the regmap API more useful but it's not required, only reg_bits and
val_bits are absolutely required.  In general the more complete the
description of the register map in the driver the better.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)