[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAOMwXhObBhWYvuEJVK7rJsb3JgALvNeoeA3xenU4L2BHdTkUVQ@mail.gmail.com>
Date: Mon, 17 Feb 2014 08:55:06 +0000
From: Laszlo Papp <lpapp@....org>
To: Mark Brown <broonie@...nel.org>
Cc: Lee Jones <lee.jones@...aro.org>,
Linus Walleij <linus.walleij@...aro.org>,
LKML <linux-kernel@...r.kernel.org>,
Krzysztof Kozlowski <k.kozlowski@...sung.com>,
Sachin Kamat <sachin.kamat@...aro.org>,
Jean Delvare <jdelvare@...e.de>,
Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH v6] mfd: MAX6650/6651 support
On Fri, Feb 14, 2014 at 8:57 PM, Mark Brown <broonie@...nel.org> wrote:
> On Fri, Feb 14, 2014 at 09:02:20AM +0000, Laszlo Papp wrote:
>> On Wed, Feb 12, 2014 at 5:50 PM, Mark Brown <broonie@...nel.org> wrote:
>> > On Wed, Feb 12, 2014 at 04:02:40AM +0000, Laszlo Papp wrote:
>
>> >> +const struct regmap_config max665x_regmap_config = {
>> >> + .reg_bits = 5,
>> >> +};
>
>> > This would normally be static too, and I'd *really* expect to see a
>> > val_bits set here. I'm a bit surprised this works without one.
>
>> Makes sense, thanks. Shall I also set the .max_register or any other
>> mandatory variables in here?
>
> It's better to set max_register since that makes the debug features of
> the regmap API more useful but it's not required, only reg_bits and
> val_bits are absolutely required. In general the more complete the
> description of the register map in the driver the better.
OK, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists