linux-kernel - Re: [PATCH] drivers/rpmsg/virtio_rpmsg_bus.c: fix the return value of rpmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140218141934.902737c24a0b46ef42e6ea9a@linux-foundation.org>
Date:	Tue, 18 Feb 2014 14:19:34 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Barry Song <21cnbao@...il.com>
Cc:	ohad@...ery.com, linux-kernel@...r.kernel.org,
	workgroup.linux@....com, Wei Chen <Wei.Chen@....com>,
	Barry Song <Baohua.Song@....com>
Subject: Re: [PATCH] drivers/rpmsg/virtio_rpmsg_bus.c: fix the return value
 of rpmsg_init

On Mon, 17 Feb 2014 16:13:34 +0800 Barry Song <21cnbao@...il.com> wrote:

> From: Wei Chen <Wei.Chen@....com>
> 
> rpmsg_init() always return ERROR code or random integer now, this patch fixes
> it.
> 
> ...
>
> --- a/drivers/rpmsg/virtio_rpmsg_bus.c
> +++ b/drivers/rpmsg/virtio_rpmsg_bus.c
> @@ -1096,9 +1096,10 @@ static int __init rpmsg_init(void)
>  	if (ret) {
>  		pr_err("failed to register virtio driver: %d\n", ret);
>  		bus_unregister(&rpmsg_bus);
> +		return ret;
>  	}
>  
> -	return ret;
> +	return 0;
>  }

Look more closely.  This patch has no effect...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/