linux-kernel - Re: [PATCH 2/2] misc: add missing minor nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Feb 2014 19:46:02 +0000
From:	Mark Jackson <mpfj-list@...flow.co.uk>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Lucas De Marchi <lucas.de.marchi@...il.com>,
	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
CC:	kay.sievers@...y.org, linux-kernel@...r.kernel.org,
	Rob Landley <rob@...dley.net>,
	Lucas De Marchi <lucas.demarchi@...el.com>
Subject: Re: [PATCH 2/2] misc: add missing minor nodes

On 18/02/14 18:52, Greg Kroah-Hartman wrote:
> On Tue, Feb 18, 2014 at 02:27:25AM -0300, Lucas De Marchi wrote:
>> From: Lucas De Marchi <lucas.demarchi@...el.com>
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@...el.com>
>> ---
>>  Documentation/devices.txt | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devices.txt b/Documentation/devices.txt
>> index 04356f5..0ea1cc2 100644
>> --- a/Documentation/devices.txt
>> +++ b/Documentation/devices.txt
>> @@ -329,6 +329,7 @@ Your cooperation is appreciated.
>>  		filesystem across multiple physical disks.
>>  
>>   10 char	Non-serial mice, misc features
>> +		  0 = /dev/fram
>>  		  0 = /dev/logibm	Logitech bus mouse
>>  		  1 = /dev/psaux	PS/2-style mouse port
>>  		  2 = /dev/inportbm	Microsoft Inport bus mouse
> 
> That's not ok at all, and probably a bug, someone must have thought that
> minor 0 ment "give me a dynamic number."  No one caught this when the
> driver was first merged in a arch-specific tree in 2008 :(
> 
> In looking at the driver, it probably should just be a UIO driver, or
> something else, all it does it map frame buffer memory to userspace,
> given the hardware involved, odds are no one even uses it anymore...
> 
> Mark and Haavard, any thoughts about the
> arch/avr32/boards/mimc200/fram.c driver?  Can I fix up the minor number
> here, or just delete the driver entirely if it's not being used anymore?

I think it's safe to delete the driver.

The mimc200 unit is now basically obsolete and there'll be no new development on it.

Regards
Mark J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/