lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140220120340.GB21048@pengutronix.de>
Date:	Thu, 20 Feb 2014 13:03:40 +0100
From:	Markus Pargmann <mpa@...gutronix.de>
To:	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	kernel@...gutronix.de, stable@...r.kernel.org
Subject: Re: [PATCH v2 2/2] regulator: core: Replace direct ops->disable usage

On Thu, Feb 20, 2014 at 12:07:52PM +0100, Markus Pargmann wrote:
> There are many places where ops->disable is called directly. Instead we
> should use _regulator_do_disable() which also handles gpio regulators.
> 
> Cc: <stable@...r.kernel.org> # 3.10+
> Signed-off-by: Markus Pargmann <mpa@...gutronix.de>
> ---
>  drivers/regulator/core.c | 32 +++++++++++++-------------------
>  1 file changed, 13 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index 017f5cb..a0c916f 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c

...

> @@ -3641,12 +3637,10 @@ int regulator_suspend_finish(void)
>  		} else {
>  			if (!have_full_constraints())
>  				goto unlock;
> -			if (!ops->disable)
> -				goto unlock;
>  			if (!_regulator_is_enabled(rdev))
>  				goto unlock;
>  
> -			error = ops->disable(rdev);
> +			error = _regulator_do_disable(rdev);

ops is unused and creates a compile warning. I will resend later with
the 'ops' variable removed from the function.

Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ