linux-kernel - Re: [PATCH v2 2/2] regulator: core: Replace direct ops->disable usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140220125130.GQ2669@sirena.org.uk>
Date:	Thu, 20 Feb 2014 21:51:30 +0900
From:	Mark Brown <broonie@...nel.org>
To:	Markus Pargmann <mpa@...gutronix.de>
Cc:	Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, kernel@...gutronix.de,
	stable@...r.kernel.org
Subject: Re: [PATCH v2 2/2] regulator: core: Replace direct ops->disable usage

On Thu, Feb 20, 2014 at 12:07:52PM +0100, Markus Pargmann wrote:

> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -1908,8 +1908,6 @@ static int _regulator_do_disable(struct regulator_dev *rdev)
>  
>  	trace_regulator_disable_complete(rdev_get_name(rdev));
>  
> -	_notifier_call_chain(rdev, REGULATOR_EVENT_DISABLE,
> -			     NULL);
>  	return 0;
>  }
>  
> @@ -1933,6 +1931,8 @@ static int _regulator_disable(struct regulator_dev *rdev)
>  				rdev_err(rdev, "failed to disable\n");
>  				return ret;
>  			}
> +			_notifier_call_chain(rdev, REGULATOR_EVENT_DISABLE,
> +					NULL);
>  		}
>  
>  		rdev->use_count = 0;

This change doesn't seem obviously related?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)