linux-kernel - Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140221120454.GD8783@e106331-lin.cambridge.arm.com>
Date:	Fri, 21 Feb 2014 12:04:54 +0000
From:	Mark Rutland <mark.rutland@....com>
To:	Felipe Balbi <balbi@...com>,
	Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@...inx.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"michals@...inx.com" <michals@...inx.com>,
	Subbaraya Sundeep Bhatta <sbhatta@...inx.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support


On Thu, Feb 20, 2014 at 06:23:13PM +0000, Felipe Balbi wrote:
> Hi,
> 
> On Wed, Feb 19, 2014 at 03:10:45PM +0530, Subbaraya Sundeep Bhatta wrote:
> > This patch adds xilinx axi usb2 device driver support
> > 
> > Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@...inx.com>
> > ---
> >  .../devicetree/bindings/usb/xilinx_usb.txt         |   21 +
> >  drivers/usb/gadget/Kconfig                         |   14 +
> >  drivers/usb/gadget/Makefile                        |    1 +
> >  drivers/usb/gadget/xilinx_udc.c                    | 2045 ++++++++++++++++++++
> >  4 files changed, 2081 insertions(+), 0 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/usb/xilinx_usb.txt
> >  create mode 100644 drivers/usb/gadget/xilinx_udc.c
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/xilinx_usb.txt b/Documentation/devicetree/bindings/usb/xilinx_usb.txt
> > new file mode 100644
> > index 0000000..acf03ab
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/xilinx_usb.txt
> > @@ -0,0 +1,21 @@
> > +Xilinx AXI USB2 device controller
> > +
> > +Required properties:
> > +- compatible		: Should be "xlnx,axi-usb2-device-4.00.a"

Is "axi-usb2-device" the official device name?

> > +- reg			: Physical base address and size of the Axi USB2
> > +			  device registers map.
> > +- interrupts		: Property with a value describing the interrupt
> > +			  number.

Does the device only have a single interrupt?

> > +- interrupt-parent	: Must be core interrupt controller

Is this strictly necessary?

> > +- xlnx,include-dma	: Must be 1 or 0 based on whether DMA is included
> > +			  in IP or not.

Perhaps xlnx,has-builtin-dma would better describe this?

> > +
> > +Example:
> > + 		axi-usb2-device@...00000 {
> > +                        compatible = "xlnx,axi-usb2-device-4.00.a";
> > +                        interrupt-parent = <0x1>;
> > +                        interrupts = <0x0 0x39 0x1>;
> > +                        reg = <0x42e00000 0x10000>;
> > +                        xlnx,include-dma = <0x1>;
> > +                };
> > +
> 
> you need to Cc devicetree@...r.kernel.org for this.

Cheers Filipe; thanks for adding us to Cc :)

[...]

> > +	/* Map the registers */
> > +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > +	udc->base_address = devm_ioremap_nocache(&pdev->dev, res->start,
> > +						 resource_size(res));
> 
> use devm_ioremap_resource() instead.

Also, res might be NULL. You should check that before dereferencing it.

Cheers,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/