lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 22 Feb 2014 23:28:19 +0100 From: Pavel Machek <pavel@....cz> To: Lorenzo Pieralisi <lorenzo.pieralisi@....com> Cc: Russell King - ARM Linux <linux@....linux.org.uk>, Sebastian Capella <sebastian.capella@...aro.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>, "linaro-kernel@...ts.linaro.org" <linaro-kernel@...ts.linaro.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Russ Dill <Russ.Dill@...com>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Len Brown <len.brown@...el.com>, Nicolas Pitre <nico@...aro.org>, Santosh Shilimkar <santosh.shilimkar@...com>, Will Deacon <Will.Deacon@....com>, Cyril Chemparathy <cyril@...com>, Jonathan Austin <Jonathan.Austin@....com>, Catalin Marinas <Catalin.Marinas@....com>, Uwe Kleine-K?nig <u.kleine-koenig@...gutronix.de>, Stephen Boyd <sboyd@...eaurora.org> Subject: Re: [PATCH RFC v1 3/3] ARM hibernation / suspend-to-disk Hi! > > return from the finisher will always be interpreted as an abort rather > > than success (because the state has to be unwound.) > > > > This is the only way to get a zero return from cpu_suspend(). > > Yes, that's the only reason why this code is jumping to cpu_resume, since > all it is needed is to snapshot the CPU context and by the time the > finisher is called that's done. Wanted to say that soft reboot is not > useful (cache flushing and resume with MMU off), but what you are saying > is correct. We might be saving swsusp_save return value in a global > variable and just return from the finisher, but that's horrible and > given the amount of time it takes to snapshot the image to disk the > cost of this soft reboot will be dwarfed by that. I feel bad for the "global variable" trick on x86, and if you can avoid it, please do! Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists