linux-kernel - Re: [PATCH v11] gpio: add a driver for the Synopsys DesignWare APB GPIO block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Feb 2014 13:20:05 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	delicious quinoa <delicious.quinoa@...il.com>
Cc:	Linus Walleij <linus.walleij@...aro.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Jamie Iles <jamie@...ieiles.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Mark Rutland <mark.rutland@....com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Steffen Trumtrar <s.trumtrar@...gutronix.de>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Heiko Stuebner <heiko@...ech.de>, Alan Tull <atull@...era.com>,
	Dinh Nguyen <dinguyen@...era.com>,
	Yves Vandervennet <rocket.yvanderv@...il.com>
Subject: Re: [PATCH v11] gpio: add a driver for the Synopsys DesignWare APB
 GPIO block

On Wed, Feb 12, 2014 at 5:17 PM, delicious quinoa
<delicious.quinoa@...il.com> wrote:

> I am wondering about the change in usage of
> irq_find_mapping/irq_create_mapping.  It seems like all the GPIO
> drivers that use irq domains do it the way I was doing it

It is a well known problems that the kernel contain many bad
examples. When in doubt ask for a good example to be provided.

In gpio-omap.c you will find that this is done in the probe()
path.

> (that's
> where I got the idea in the first place): irq_create_mapping is used
> in the to_irq() function.  I guess this is a general direction all the
> other drivers will be encouraged to go in also?

Yes. The reason is that it should be possible to reques an IRQ
from an irqchip no matter whether the gpio_to_irq() function
was called first, as the APIs are orthogonal.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/