linux-kernel - Re: [PATCH v11] gpio: add a driver for the Synopsys DesignWare APB GPIO block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANk1AXR+JhJ9Q=yqpAJA4efLkaJ28jBMqsrLiYBrE+xV0f1G0g@mail.gmail.com>
Date:	Mon, 24 Feb 2014 08:20:53 -0600
From:	delicious quinoa <delicious.quinoa@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Linus Walleij <linus.walleij@...aro.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Jamie Iles <jamie@...ieiles.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Mark Rutland <mark.rutland@....com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Steffen Trumtrar <s.trumtrar@...gutronix.de>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Heiko Stuebner <heiko@...ech.de>, Alan Tull <atull@...era.com>,
	Dinh Nguyen <dinguyen@...era.com>,
	Yves Vandervennet <rocket.yvanderv@...il.com>
Subject: Re: [PATCH v11] gpio: add a driver for the Synopsys DesignWare APB
 GPIO block

On Mon, Feb 24, 2014 at 6:20 AM, Linus Walleij <linus.walleij@...aro.org> wrote:
> On Wed, Feb 12, 2014 at 5:17 PM, delicious quinoa
> <delicious.quinoa@...il.com> wrote:
>
>> I am wondering about the change in usage of
>> irq_find_mapping/irq_create_mapping.  It seems like all the GPIO
>> drivers that use irq domains do it the way I was doing it
>
> It is a well known problems that the kernel contain many bad
> examples. When in doubt ask for a good example to be provided.
>
> In gpio-omap.c you will find that this is done in the probe()
> path.
>
>> (that's
>> where I got the idea in the first place): irq_create_mapping is used
>> in the to_irq() function.  I guess this is a general direction all the
>> other drivers will be encouraged to go in also?
>
> Yes. The reason is that it should be possible to reques an IRQ
> from an irqchip no matter whether the gpio_to_irq() function
> was called first, as the APIs are orthogonal.
>
> Yours,
> Linus Walleij

Hi Linus,

Thanks, I made these changes and can see them working for me.

The thing that is currently holding me up is that the DesignWare IP
can be configured to have one irq exiting for the many gpios on port A
or one gpio exiting for each gpio.  I am trying to figure out how to
support both cases with the simplest code.  Currently support works
for the one irq case.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/