linux-kernel - Re: [PATCH RESEND] x86: iosf_mbi: Provide dummy functions if CONFIG_IOSF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140224132916.69b95bf5@alan.etchedpixels.co.uk>
Date:	Mon, 24 Feb 2014 13:29:16 +0000
From:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	"David E. Box" <david.e.box@...ux.intel.com>, tglx@...utronix.de,
	mingo@...hat.com, x86@...nel.org, linux-kernel@...r.kernel.org,
	srinivas.pandruvada@...ux.intel.com, jacob.jun.pan@...el.com
Subject: Re: [PATCH RESEND] x86: iosf_mbi: Provide dummy functions if
 CONFIG_IOSF_MBI not set

On Mon, 24 Feb 2014 05:21:43 -0800
"H. Peter Anvin" <hpa@...or.com> wrote:

> On 02/24/2014 05:19 AM, One Thousand Gnomes wrote:
> >
> > Other than _available I would have expected all the others to resolve to
> > returning an error or doing a WARN() in the not compiled in case.
> >
> 
> WARN() or BUG()?

WARN I think. The usage cases I am aware of don't end up in catastrophic
failure if you get this wrong, but would be annoying to debug if missed.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/