linux-kernel - Re: [PATCH] checkpatch.pl: Add warning for new _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140224213128.GB12233@cloud>
Date:	Mon, 24 Feb 2014 13:31:28 -0800
From:	josh@...htriplett.org
To:	Tom Rini <trini@...com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH] checkpatch.pl: Add warning for new __packed additions

On Mon, Feb 24, 2014 at 03:38:16PM -0500, Tom Rini wrote:
> While there are valid reasons to use __packed, often the answer is that
> you should be doing something else here instead.
> 
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Joe Perches <joe@...ches.com>
> Cc: Josh Triplett <josh@...htriplett.org>
> Signed-off-by: Tom Rini <trini@...com>
> ---
>  scripts/checkpatch.pl |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 0ea2a1e..fef3b13 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4010,6 +4010,11 @@ sub process {
>  			WARN("PREFER_PACKED",
>  			     "__packed is preferred over __attribute__((packed))\n" . $herecurr);
>  		}
> +# Check for new packed usage, warn to use care
> +		if ($line =~ /\b(__attribute__\s*\(\s*\(.*\bpacked|__packed)\b/) {
> +			WARN("NEW_PACKED",
> +			     "Adding new packed members is to be done with care\n" . $herecurr);
> +		}

This seems wrong; "is to be done with care" is the very definition of a
false positive.  At *best* this should always be CHK, and even then it
seems excessive.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/