linux-kernel - Re: [patch 07/26] pci: pcie-designware: Remove irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Feb 2014 14:38:11 -0700
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	Mohit Kumar <mohit.kumar@...com>,
	pci <linux-pci@...r.kernel.org>
Subject: Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse

On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han <jg1.han@...sung.com> wrote:
> On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote:
>>
>> There is no reason to care about irq_desc in that context, escpecially
>> as irq_data for that interrupt is retrieved as well.
>>
>> Use the proper accessor for the msi descriptor
>>
>> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
>> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
>> Cc: Jingoo Han <jg1.han@...sung.com>
>> Cc: Mohit Kumar <mohit.kumar@...com>
>> Cc: pci <linux-pci@...r.kernel.org>
>
> Acked-by: Jingoo Han <jg1.han@...sung.com>

Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>

Thomas, I assume you'll merge this along with the rest of your series.
 I don't have any pending changes in this area.

Bjorn

> A few days ago, I noticed that irq_data_get_msi() can be used.
> However, I did not submit the same patch. I really appreciate
> your patch. :-)
>
> Best regards,
> Jingoo Han
>
>> ---
>>  drivers/pci/host/pcie-designware.c |    4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> Index: tip/drivers/pci/host/pcie-designware.c
>> ===================================================================
>> --- tip.orig/drivers/pci/host/pcie-designware.c
>> +++ tip/drivers/pci/host/pcie-designware.c
>> @@ -294,14 +294,12 @@ no_valid_irq:
>>  static void clear_irq(unsigned int irq)
>>  {
>>       unsigned int pos, nvec;
>> -     struct irq_desc *desc;
>>       struct msi_desc *msi;
>>       struct pcie_port *pp;
>>       struct irq_data *data = irq_get_irq_data(irq);
>>
>>       /* get the port structure */
>> -     desc = irq_to_desc(irq);
>> -     msi = irq_desc_get_msi_desc(desc);
>> +     msi = irq_data_get_msi(data);
>>       pp = sys_to_pcie(msi->dev->bus->sysdata);
>>       if (!pp) {
>>               BUG();
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/