linux-kernel - Re: [PATCH 1/1] Char: ipmi_bt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <530D1021.1050402@acm.org>
Date:	Tue, 25 Feb 2014 15:50:25 -0600
From:	Corey Minyard <minyard@....org>
To:	Jiri Slaby <jslaby@...e.cz>
CC:	jirislaby@...il.com, linux-kernel@...r.kernel.org,
	Tomas Cech <tcech@...e.cz>,
	openipmi-developer@...ts.sourceforge.net,
	Rocky Craig <rocky.craig@...com>
Subject: Re: [PATCH 1/1] Char: ipmi_bt_sm, fix infinite loop

Looks right to me.  Rocky, copying you in case there's an issue with this.

Thanks,

-corey

On 02/25/2014 04:14 AM, Jiri Slaby wrote:
> In read_all_bytes, we do
>   unsigned char i;
> ...
>   bt->read_data[0] = BMC2HOST;
>   bt->read_count = bt->read_data[0];
> ...
>   for (i = 1; i <= bt->read_count; i++)
>     bt->read_data[i] = BMC2HOST;
>
> If bt->read_data[0] == bt->read_count == 255, we loop infinitely in
> the 'for' loop. Make 'i' an 'int' instead of 'char' to get rid of the
> overflow and finish the loop after 255 iterations every time.
>
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Reported-and-debugged-by: Rui Hui Dian <rhdian@...ell.com>
> Cc: Tomas Cech <tcech@...e.cz>
> Cc: Corey Minyard <minyard@....org>
> Cc: <openipmi-developer@...ts.sourceforge.net>
> ---
>  drivers/char/ipmi/ipmi_bt_sm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_bt_sm.c b/drivers/char/ipmi/ipmi_bt_sm.c
> index f5e4cd7617f6..61e71616689b 100644
> --- a/drivers/char/ipmi/ipmi_bt_sm.c
> +++ b/drivers/char/ipmi/ipmi_bt_sm.c
> @@ -352,7 +352,7 @@ static inline void write_all_bytes(struct si_sm_data *bt)
>  
>  static inline int read_all_bytes(struct si_sm_data *bt)
>  {
> -	unsigned char i;
> +	unsigned int i;
>  
>  	/*
>  	 * length is "framing info", minimum = 4: NetFn, Seq, Cmd, cCode.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/