linux-kernel - Re: [PATCH] ACPI / EC: Clear stale EC events on Samsung systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Feb 2014 11:15:05 +1030
From:	Kieran Clancy <clancy.kieran@...il.com>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Lan Tianyu <tianyu.lan@...el.com>,
	Juan Manuel Cabo <juanmanuel.cabo@...il.com>,
	Dennis Jansen <dennis.jansen@....de>
Subject: Re: [PATCH] ACPI / EC: Clear stale EC events on Samsung systems

On Thu, Feb 27, 2014 at 10:15 AM, Rafael J. Wysocki <rjw@...ysocki.net> wrote:
> On Thursday, February 27, 2014 02:12:40 AM Kieran Clancy wrote:
>> Signed-off-by: Kieran Clancy <clancy.kieran@...il.com>
>> Signed-off-by: Lan Tianyu <tianyu.lan@...el.com>
>> Signed-off-by: Juan Manuel Cabo <juanmanuel.cabo@...il.com>
>> Signed-off-by: Dennis Jansen <dennis.jansen@....de>
>
> There are too many sign-offs under this patch.  I suppose some of them
> should be Acked-by or Reviewed-by.
>
> Are you the author?

Sorry about that, I wasn't sure of the best way to acknowledge the
people involved.

I am the primary author, but I based the loop which calls
acpi_ec_query_unlocked() on a patch by Lan Tianyu. Juan provided the
initial idea (userspace workaround), and Dennis and Lan Tianyu
reviewed and suggested some changes to the code.

What would you usually do this kind of situation?

I suppose I could put something such as:

Signed-off-by: Kieran Clancy <clancy.kieran@...il.com>
Signed-off-by: Lan Tianyu <tianyu.lan@...el.com>
Suggested-by: Juan Manuel Cabo <juanmanuel.cabo@...il.com>
Reviewed-by: Lan Tianyu <tianyu.lan@...el.com>
Reviewed-by: Dennis Jansen <dennis.jansen@....de>

Would this be preferable?

Thanks,
Kieran Clancy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/