linux-kernel - Re: [PATCH 0/4] Provide netdev naming-policy via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG-2HqWahCVvDLPwoMo7O4kam+W0o7BQGm4cRBvc9=X_p0fF7Q@mail.gmail.com>
Date:	Thu, 27 Feb 2014 16:47:51 +0100
From:	Tom Gundersen <teg@...m.no>
To:	David Herrmann <dh.herrmann@...il.com>
Cc:	netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Kay Sievers <kay.sievers@...y.org>,
	Johannes berg <johannes@...solutions.net>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux Wireless List <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH 0/4] Provide netdev naming-policy via sysfs

On Thu, Feb 27, 2014 at 3:47 PM, David Herrmann <dh.herrmann@...il.com> wrote:
> This series implements a new sysfs attribute for netdevs called
> "name_assign_type". It provides an integer that describes where an interface
> name comes from. See Patch #1 for a description of this attribute. It is
> modelled after the existing "addr_assign_type" attribute.
>
> The main use-case is to allow udev to skip applying reliable ifnames to virtual
> devices. For instance, if wifi-P2P devices are created, wpas already provides a
> suitable naming-policy and udev shouldn't touch these devices. Same is true for
> other virtual devices.
> The idea is that if a device-name was provided by user-space, we should always
> prefer fixing this naming-policy instead of making udev rename the device. For
> kernel provided names that's hardly possible, though. Providing the
> naming-policy source via sysfs is thus a simple way to see whether renames are
> needed.
>
> Additionally, this field allows to detect whether a netdev has been manually
> renamed, which is quite useful for debugging and during crash-recovery.

Moreover, it would be useful for udev to reliably know if some other
userspace process already renamed a device, so we know not to touch
it. This can easily happen for instance if some renaming happens in
the initrd or from script called from udev rules.

Acked-by: Tom Gundersen <teg@...m.no>

> David Herrmann (4):
>   net: add name_assign_type netdev attribute
>   mac80211: set NET_NAME_USER for user-space created ifs
>   ath6kl: set NET_NAME_USER for P2P ifs
>   brcmfmac: set NET_NAME_USER for P2P ifs
>
>  drivers/net/wireless/ath/ath6kl/cfg80211.c    | 5 ++++-
>  drivers/net/wireless/ath/ath6kl/cfg80211.h    | 1 +
>  drivers/net/wireless/ath/ath6kl/core.c        | 4 ++--
>  drivers/net/wireless/brcm80211/brcmfmac/p2p.c | 1 +
>  include/linux/netdevice.h                     | 6 ++++++
>  net/core/dev.c                                | 7 +++++++
>  net/core/net-sysfs.c                          | 2 ++
>  net/core/rtnetlink.c                          | 2 ++
>  net/mac80211/iface.c                          | 1 +
>  9 files changed, 26 insertions(+), 3 deletions(-)
>
> --
> 1.9.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/