linux-kernel - Re: [PATCH 35/46] kernel: Mark function as static in kernel/seccomp.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABqD9haxuQv9FG1a+r79UYuhs9xhJVeeAB3rm7xzqTqM7FcwtA@mail.gmail.com>
Date:	Thu, 27 Feb 2014 09:48:54 -0600
From:	Will Drewry <wad@...omium.org>
To:	Kees Cook <keescook@...omium.org>
Cc:	Rashika Kheria <rashika.kheria@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Nicolas Schichan <nschichan@...ebox.fr>,
	James Morris <james.l.morris@...cle.com>,
	Josh Triplett <josh@...htriplett.org>
Subject: Re: [PATCH 35/46] kernel: Mark function as static in kernel/seccomp.c

On Thu, Feb 27, 2014 at 9:33 AM, Kees Cook <keescook@...omium.org> wrote:
> On Thu, Feb 27, 2014 at 4:20 AM, Rashika Kheria
> <rashika.kheria@...il.com> wrote:
>> Mark function as static in kernel/seccomp.c because it is not used
>> outside this file.
>>
>> This eliminates the following warning in kernel/seccomp.c:
>> kernel/seccomp.c:296:6: warning: no previous prototype for 'seccomp_attach_user_filter' [-Wmissing-prototypes]
>>
>> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
>> Reviewed-by: Josh Triplett <josh@...htriplett.org>
>
> Acked-by: Kees Cook <keescook@...omium.org>

Acked-by: Will Drewry <wad@...omium.org>

It amazing what things slip through.  Thanks!

>> ---
>>  kernel/seccomp.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/seccomp.c b/kernel/seccomp.c
>> index b7a1004..0e004a7 100644
>> --- a/kernel/seccomp.c
>> +++ b/kernel/seccomp.c
>> @@ -293,7 +293,7 @@ fail:
>>   *
>>   * Returns 0 on success and non-zero otherwise.
>>   */
>> -long seccomp_attach_user_filter(char __user *user_filter)
>> +static long seccomp_attach_user_filter(char __user *user_filter)
>>  {
>>         struct sock_fprog fprog;
>>         long ret = -EFAULT;
>> --
>> 1.7.9.5
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/