linux-kernel - Re: [PATCH 26/46] kernel: Mark functions as static in kernel/trace/trace.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140227144253.3cf5c923@gandalf.local.home>
Date:	Thu, 27 Feb 2014 14:42:53 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>, josh@...htriplett.org
Subject: Re: [PATCH 26/46] kernel: Mark functions as static in
 kernel/trace/trace.c

On Thu, 27 Feb 2014 17:33:53 +0530
Rashika Kheria <rashika.kheria@...il.com> wrote:

> Mark functions as static in kernel/trace/trace.c
> because they are not used outside this file.
> 
> This eliminates the following warning in kernel/trace/trace.c:
> kernel/trace/trace.c:266:9: warning: no previous prototype for ‘buffer_ftrace_now’ [-Wmissing-prototypes]
> kernel/trace/trace.c:590:6: warning: no previous prototype for ‘free_snapshot’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve

> ---
>  kernel/trace/trace.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 815c878..f097949 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -263,7 +263,7 @@ int call_filter_check_discard(struct ftrace_event_call *call, void *rec,
>  }
>  EXPORT_SYMBOL_GPL(call_filter_check_discard);
>  
> -cycle_t buffer_ftrace_now(struct trace_buffer *buf, int cpu)
> +static cycle_t buffer_ftrace_now(struct trace_buffer *buf, int cpu)
>  {
>  	u64 ts;
>  
> @@ -587,7 +587,7 @@ static int alloc_snapshot(struct trace_array *tr)
>  	return 0;
>  }
>  
> -void free_snapshot(struct trace_array *tr)
> +static void free_snapshot(struct trace_array *tr)
>  {
>  	/*
>  	 * We don't free the ring buffer. instead, resize it because

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/