linux-kernel - Re: [PATCH 27/46] kernel: Mark function as static in kernel/trace/trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140227145412.32a79f45@gandalf.local.home>
Date:	Thu, 27 Feb 2014 14:54:12 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>, josh@...htriplett.org
Subject: Re: [PATCH 27/46] kernel: Mark function as static in
 kernel/trace/trace_selftest.c

On Thu, 27 Feb 2014 17:36:41 +0530
Rashika Kheria <rashika.kheria@...il.com> wrote:

> Mark function as static in kernel/trace/trace_selftest.c because it is
> not used outside this file.
> 
> This eliminates the following warning in kernel/trace/trace_selftest.c:
> kernel/trace/trace_selftest.c:318:5: warning: no previous prototype for ‘trace_selftest_startup_dynamic_tracing’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve

> ---
>  kernel/trace/trace_selftest.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c
> index e98fca6..bfecd63 100644
> --- a/kernel/trace/trace_selftest.c
> +++ b/kernel/trace/trace_selftest.c
> @@ -315,9 +315,9 @@ static int trace_selftest_ops(int cnt)
>  }
>  
>  /* Test dynamic code modification and ftrace filters */
> -int trace_selftest_startup_dynamic_tracing(struct tracer *trace,
> -					   struct trace_array *tr,
> -					   int (*func)(void))
> +static int trace_selftest_startup_dynamic_tracing(struct tracer *trace,
> +						  struct trace_array *tr,
> +						  int (*func)(void))
>  {
>  	int save_ftrace_enabled = ftrace_enabled;
>  	unsigned long count;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/