[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140227145624.58b5f9b1@gandalf.local.home>
Date: Thu, 27 Feb 2014 14:56:24 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Rashika Kheria <rashika.kheria@...il.com>
Cc: linux-kernel@...r.kernel.org,
Frederic Weisbecker <fweisbec@...il.com>,
Ingo Molnar <mingo@...hat.com>, josh@...htriplett.org
Subject: Re: [PATCH 28/46] kernel: Add prototype declaration to header file
linux/ftrace.h
On Thu, 27 Feb 2014 17:38:01 +0530
Rashika Kheria <rashika.kheria@...il.com> wrote:
> Add prototye declaration of function to header file
> include/linux/ftrace.h
> because it is used by more than one file.
>
> This eliminates the following warning in
> kernel/trace/trace_functions_graph.c:
> kernel/trace/trace_functions_graph.c:218:15: warning: no previous prototype for ‘ftrace_return_to_handler’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>
> ---
> include/linux/ftrace.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
> index da1c31f..c4d1048 100644
> --- a/include/linux/ftrace.h
> +++ b/include/linux/ftrace.h
> @@ -673,6 +673,7 @@ typedef void (*trace_func_graph_ret_t)(struct ftrace_graph_ret *); /* return */
> typedef int (*trace_func_graph_ent_t)(struct ftrace_graph_ent *); /* entry */
>
> int ftrace_graph_entry_stub(struct ftrace_graph_ent *trace);
> +unsigned long ftrace_return_to_handler(unsigned long frame_pointer);
Like ftrace_graph_entry_stub() this too is only called from assembly.
Just make the comment I asked to add apply to both of them.
-- Steve
>
> #ifdef CONFIG_FUNCTION_GRAPH_TRACER
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists