linux-kernel - Re: [PATCH 29/46] kernel: Mark functions as static in trace/trace_functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140227145743.32f1c4d5@gandalf.local.home>
Date:	Thu, 27 Feb 2014 14:57:43 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>, josh@...htriplett.org
Subject: Re: [PATCH 29/46] kernel: Mark functions as static in
 trace/trace_functions_graph.c

On Thu, 27 Feb 2014 17:40:11 +0530
Rashika Kheria <rashika.kheria@...il.com> wrote:

> Mark functions as static in kernel/trace/trace_functions_graph.c because
> they are not used outside this file.
> 
> This eliminates the following warning in
> kernel/trace/trace_functions_graph.c:
> kernel/trace/trace_functions_graph.c:333:5: warning: no previous prototype for ‘trace_graph_thresh_entry’ [-Wmissing-prototypes]
> kernel/trace/trace_functions_graph.c:422:6: warning: no previous prototype for ‘trace_graph_thresh_return’ [-Wmissing-prototypes]
> kernel/trace/trace_functions_graph.c:1408:6: warning: no previous prototype for ‘print_graph_headers’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve


> ---
>  kernel/trace/trace_functions_graph.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
> index 0b99120..9e9b5c2 100644
> --- a/kernel/trace/trace_functions_graph.c
> +++ b/kernel/trace/trace_functions_graph.c
> @@ -330,7 +330,7 @@ int trace_graph_entry(struct ftrace_graph_ent *trace)
>  	return ret;
>  }
>  
> -int trace_graph_thresh_entry(struct ftrace_graph_ent *trace)
> +static int trace_graph_thresh_entry(struct ftrace_graph_ent *trace)
>  {
>  	if (tracing_thresh)
>  		return 1;
> @@ -419,7 +419,7 @@ void set_graph_array(struct trace_array *tr)
>  	smp_mb();
>  }
>  
> -void trace_graph_thresh_return(struct ftrace_graph_ret *trace)
> +static void trace_graph_thresh_return(struct ftrace_graph_ret *trace)
>  {
>  	if (tracing_thresh &&
>  	    (trace->rettime - trace->calltime < tracing_thresh))
> @@ -1405,7 +1405,7 @@ static void __print_graph_headers_flags(struct seq_file *s, u32 flags)
>  	seq_printf(s, "               |   |   |   |\n");
>  }
>  
> -void print_graph_headers(struct seq_file *s)
> +static void print_graph_headers(struct seq_file *s)
>  {
>  	print_graph_headers_flags(s, tracer_flags.val);
>  }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/