linux-kernel - Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140228211758.GB2517@katana>
Date:	Fri, 28 Feb 2014 22:17:58 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	David Howells <dhowells@...hat.com>
Cc:	wolfram@...-dreams.de, khali@...ux-fr.org,
	linux-i2c@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C


> > And for the buffer: %*phN is difficult to read IMO. What about %*ph? Or
> > %*phD at least?
> 
> My problem with that is that it increases the length of the output by 50% and
> there's a hard limit on how much output we may produce.

Is it PAGE_SIZE? How is this handled when the buffer is so big that the
limit will be reached anyhow? Note that it is really uncommon to
transfer kilobytes in one go via i2c. Usually, big transfers are split
up into smaller fragments, say 128-256 byte. So, for readability, I'd
still favour %*ph.


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)