linux-kernel - Re: [PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAOfnZpW7GLb2dUfGGe7ET7QXQuNvVsjGcz_RkNy00omoM_8sw@mail.gmail.com>
Date:	Sun, 2 Mar 2014 21:51:07 +0530
From:	Yogesh Chaudhari <mr.yogesh@...il.com>
To:	Levente Kurusa <levex@...ux.com>
Cc:	Joe Perches <joe@...ches.com>, LKML <linux-kernel@...r.kernel.org>,
	Robo Bot <apw@...onical.com>
Subject: Re: [PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning
 message in case printk is used in any patch

On 2 March 2014 21:19, Levente Kurusa <levex@...ux.com> wrote:
> Hi,
>
> 2014-03-02 16:40 GMT+01:00 Joe Perches <joe@...ches.com>:
>> On Sun, 2014-03-02 at 16:20 +0100, Levente Kurusa wrote:
>>> IMHO, this message is too big. The one we already have is nice and clean.
>>> I would simply do: s/netdev/[subsystem]/ or something among the lines.
>>
>> maybe:
>>
>> "Prefer [subsystem eg: netdev]_$level2 then dev_$level2 then pr_$level to printk(KERN_$orig ...\n"
>
> Excellent, that looks the best and combines the best of two worlds.
>
>>
>> or reference the stackoverflow link
>>
>
> And what if that disappears? Might as well write this to
> Documentation/CodingStyle
> as I have previously mentioned. Yogesh, you want to do this or should I?

I will send in a new patch with both the script file and the
documentation modifications.

>
> --
> Regards,
> Levente Kurusa


Regards
Yogesh

-- 
DREAM IT, CODE IT
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/