linux-kernel - Re: [PATCH v21 00/12] Add 32 bit VDSO time function support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 2 Mar 2014 08:32:24 -0800
From:	Andy Lutomirski <luto@...capital.net>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Stefani Seibold <stefani@...bold.net>,
	Greg KH <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	X86 ML <x86@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, Andi Kleen <ak@...ux.intel.com>,
	Andrea Arcangeli <aarcange@...hat.com>,
	John Stultz <john.stultz@...aro.org>,
	Pavel Emelyanov <xemul@...allels.com>,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	andriy.shevchenko@...ux.intel.com, Martin.Runge@...de-schwarz.com,
	Andreas.Brief@...de-schwarz.com
Subject: Re: [PATCH v21 00/12] Add 32 bit VDSO time function support

On Sun, Mar 2, 2014 at 2:47 AM, Ingo Molnar <mingo@...nel.org> wrote:
>
> * Stefani Seibold <stefani@...bold.net> wrote:
>
>> This patch add the functions vdso_gettimeofday(), vdso_clock_gettime()
>> and vdso_time() to the 32 bit VDSO.
>
> What I'm missing from all the series is any trace of the significant
> review and debug work that Andy Lutomirski did for the series. Please
> add Acked-by or Reviewed-by tags to credit his contributions, as
> appropriate. (if Andy is fine with that.)
>

I'm okay w/ Reviewed-by, except for the patch for 32-bit vdso on
64-bit, which I haven't really reviewed (nor do I feel fully qualified
to review it -- it's a bit of a core change, and I'd prefer for
someone involved in that code to comment on it).

For the patches I wrote, "From" would be nice :)

OTOH, hpa may prefer incremental patches, now that this lives in tip.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/