linux-kernel - Re: [PATCH] input: ff-memless: don't schedule already playing effect to play again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1433818.6pzd5XvsiT@sigyn>
Date:	Sun, 02 Mar 2014 14:37:11 +0100
From:	Michal Malý <madcatxster@...fuk.cz>
To:	Felix Rueegg <felix.rueegg@...il.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: ff-memless: don't schedule already playing effect to play again

On Sunday 02 of March 2014 14:17:58 you wrote:
> On Sun, Mar 2, 2014 at 12:35 PM, Felix Rueegg 
<felix.rueegg@...il.com> wrote:
> > When an effect with zero replay length, zero replay delay
> > and zero envelope attack length is uploaded, it is played and then
> > scheduled to play again one timer tick later. This triggers a 
warning
> > (URB submitted while active) in combination with the xpad driver.
> > 
> > Skipping the rescheduling of this effect fixes the issue.
> > 
> > Signed-off-by: Felix Rueegg <felix.rueegg@...il.com>
> > ---
> > 
> >  drivers/input/ff-memless.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/input/ff-memless.c b/drivers/input/ff-memless.c
> > index 74c0d8c..2e06948 100644
> > --- a/drivers/input/ff-memless.c
> > +++ b/drivers/input/ff-memless.c
> > @@ -139,10 +139,13 @@ static void ml_schedule_timer(struct 
ml_device *ml)
> > 
> >                 if (!test_bit(FF_EFFECT_STARTED, &state->flags))
> >                 
> >                         continue;
> > 
> > -               if (test_bit(FF_EFFECT_PLAYING, &state->flags))
> > +               if (test_bit(FF_EFFECT_PLAYING, &state->flags)) {
> > 
> >                         next_at = calculate_next_time(state);
> > 
> > -               else
> > +                       if (next_at == now)
> > +                               continue;
> > +               } else {
> > 
> >                         next_at = state->play_at;
> > 
> > +               }
> > 
> >                 if (time_before_eq(now, next_at) &&
> >                 
> >                     (++events == 1 || time_before(next_at, earliest)))
> > 
> > --
> > 1.9.0
> > 
> > --
> 
> @Michal: Is ff-memless-next also affected by this problem?
> 
> Elias

I hope it's not, see mlnx_get_envelope_update_time(), this part in 
particular:

        /* Prevent the effect from being started twice */
        if (mlnxeff->begin_at == now && mlnx_is_playing(mlnxeff))
                return now - 1;

        return mlnxeff->begin_at;

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/