linux-kernel - Re: [PATCH 1/1] mm: use macros from compiler.h instead of __attribute_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140304132604.5be1b967068f8e03820d2169@linux-foundation.org>
Date:	Tue, 4 Mar 2014 13:26:04 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Gideon Israel Dsouza <gidisrael@...il.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	geert@...ux-m68k.org
Subject: Re: [PATCH 1/1] mm: use macros from compiler.h instead of
 __attribute__((...))

On Sun,  2 Mar 2014 19:09:58 +0530 Gideon Israel Dsouza <gidisrael@...il.com> wrote:

> To increase compiler portability there is <linux/compiler.h> which
> provides convenience macros for various gcc constructs.  Eg: __weak
> for __attribute__((weak)).  I've replaced all instances of gcc
> attributes with the right macro in the memory management
> (/mm) subsystem.
> 
> ...
>
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -13,6 +13,7 @@
>  #include <linux/nodemask.h>
>  #include <linux/pagemap.h>
>  #include <linux/mempolicy.h>
> +#include <linux/compiler.h>

It may be overdoing things a bit to explicitly include compiler.h. 
It's hard to conceive of any .c file which doesn't already include it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/