linux-kernel - Re: [PATCH 1/1] mm: use macros from compiler.h instead of __attribute_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140305102755.6e44b7e1e6eb62f01c41c018@canb.auug.org.au>
Date:	Wed, 5 Mar 2014 10:27:55 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Gideon Israel Dsouza <gidisrael@...il.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, geert@...ux-m68k.org
Subject: Re: [PATCH 1/1] mm: use macros from compiler.h instead of
 __attribute__((...))

Hi Andrew,

On Tue, 4 Mar 2014 13:26:04 -0800 Andrew Morton <akpm@...ux-foundation.org> wrote:
>
> On Sun,  2 Mar 2014 19:09:58 +0530 Gideon Israel Dsouza <gidisrael@...il.com> wrote:
> 
> > To increase compiler portability there is <linux/compiler.h> which
> > provides convenience macros for various gcc constructs.  Eg: __weak
> > for __attribute__((weak)).  I've replaced all instances of gcc
> > attributes with the right macro in the memory management
> > (/mm) subsystem.
> > 
> > ...
> >
> > --- a/mm/hugetlb.c
> > +++ b/mm/hugetlb.c
> > @@ -13,6 +13,7 @@
> >  #include <linux/nodemask.h>
> >  #include <linux/pagemap.h>
> >  #include <linux/mempolicy.h>
> > +#include <linux/compiler.h>
> 
> It may be overdoing things a bit to explicitly include compiler.h. 
> It's hard to conceive of any .c file which doesn't already include it.

Stick to Rule 1 :-)

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped