linux-kernel - Re: [PATCH] iommu/amd: Fix logics to determine and checking max PASID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5317AE79.6090606@amd.com>
Date:	Wed, 5 Mar 2014 17:08:41 -0600
From:	Suravee Suthikulanit <suravee.suthikulpanit@....com>
To:	Joerg Roedel <joro@...tes.org>
CC:	<iommu@...ts.linux-foundation.org>, <linux-kernel@...r.kernel.org>,
	<kim.naru@....com>, <jay.cornwall@....com>
Subject: Re: [PATCH] iommu/amd: Fix logics to determine and checking max PASID

On 3/5/2014 4:35 PM, Joerg Roedel wrote:
>> -		cmd->data[1]  = pasid & PASID_MASK;
>> >+		cmd->data[1]  = pasid & amd_iommu_max_pasid;
> ... masking out the other bits is redundant.
>
>
> 	Joerg

Agree.  I can take out the masking stuff here, but I think we should be 
using the amd_iommu_max_pasid instead of hard coded PASID_MASK for the rest.

Suravee


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/