linux-kernel - Re: [PATCH 1/1] blktrace: fix accounting of partially completed requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5317AED1.4050104@kernel.dk>
Date:	Wed, 05 Mar 2014 16:10:09 -0700
From:	Jens Axboe <axboe@...nel.dk>
To:	Roman Pen <r.peniaev@...il.com>
CC:	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] blktrace: fix accounting of partially completed requests

On 03/04/2014 07:13 AM, Roman Pen wrote:
> trace_block_rq_complete does not take into account that request can
> be partially completed, so we can get the following incorrect output
> of blkparser:
>
>    C   R 232 + 240 [0]
>    C   R 240 + 232 [0]
>    C   R 248 + 224 [0]
>    C   R 256 + 216 [0]
>
> but should be:
>
>    C   R 232 + 8 [0]
>    C   R 240 + 8 [0]
>    C   R 248 + 8 [0]
>    C   R 256 + 8 [0]
>
> Also, the whole output summary statistics of completed requests and
> final throughput will be incorrect.
>
> This patch takes into account real completion size of the request and
> fixes wrong completion accounting.

Thanks Roman, this looks good. I'll apply it for 3.15, but with an added 
stable tag as well.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/