linux-kernel - Re: [PATCH] audit: remove stray newlines from audit_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140305231154.GY16640@madcap2.tricolour.ca>
Date:	Wed, 5 Mar 2014 18:11:54 -0500
From:	Richard Guy Briggs <rgb@...hat.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Josh Boyer <jwboyer@...oraproject.org>,
	Eric Paris <eparis@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] audit: remove stray newlines from audit_log_lost messages

On 14/03/05, Joe Perches wrote:
> On Wed, 2014-03-05 at 17:27 -0500, Richard Guy Briggs wrote:
> > On 14/03/05, Josh Boyer wrote:
> > > Calling audit_log_lost with a \n in the format string leads to extra
> > > newlines in dmesg.  That function will eventually call audit_panic which
> > > uses pr_err with an explicit \n included.  Just make these calls match the
> > > others that lack \n.
> > > 
> > > Reported-by: Jonathan Kamens <jik@...ens.brookline.ma.us>
> > > Signed-off-by: Josh Boyer <jwboyer@...oraproject.org>
> > 
> > Ack.  queued.
> 
> There's an unnecessary use of a \n in audit_panic too

Thanks, also queued.

> ---
>  kernel/auditsc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index 7aef2f4..da93d2e 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -1157,7 +1157,7 @@ static void audit_log_execve_info(struct audit_context *context,
>  	 */
>  	buf = kmalloc(MAX_EXECVE_AUDIT_LEN + 1, GFP_KERNEL);
>  	if (!buf) {
> -		audit_panic("out of memory for argv string\n");
> +		audit_panic("out of memory for argv string");
>  		return;
>  	}
>  
> 
> 

- RGB

--
Richard Guy Briggs <rbriggs@...hat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/