linux-kernel - Re: [alsa-devel] [PATCH 01/10] ASoC: core: Add snd_soc_dai_set_tdm_slot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140305033935.GY13126@sirena.org.uk>
Date:	Wed, 5 Mar 2014 11:39:35 +0800
From:	Mark Brown <broonie@...nel.org>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Xiubo Li <Li.Xiubo@...escale.com>, lgirdwood@...il.com,
	fabio.estevam@...escale.com, moinejf@...e.fr,
	alsa-devel@...a-project.org, kuninori.morimoto.gx@...esas.com,
	tiwai@...e.de, s.hauer@...gutronix.de, timur@...i.org,
	linux-kernel@...r.kernel.org, denis@...rea.com,
	Guangyu.Chen@...escale.com, mpa@...gutronix.de,
	shawn.guo@...aro.org
Subject: Re: [alsa-devel] [PATCH 01/10] ASoC: core: Add
 snd_soc_dai_set_tdm_slot_xlate().

On Sat, Mar 01, 2014 at 02:19:44PM +0100, Lars-Peter Clausen wrote:

> I'm not quite sure I fully understand what this patch is trying to
> solve. It adds a variant snd_soc_dai_set_tdm_slot() that instead of
> taking a rx and tx mask calculates the masks based on the number of
> slots? In that case I don't really see how the xlate in the name
> relates to that. xlate is something you'd typically expect in a
> devicetree context. Maybe one should be called
> snd_soc_dai_set_tdm_slot() and the other
> snd_soc_dai_set_tdm_slot_and_masks()?

> But another question is do we really need this? I don't see the
> problem that is solved by this patchset.

My understanding is that the patch set aims to provide a way of using
the TDM features of drivers from DT, providing a standardised format for
expressing the TDM setup in the DT.  I've not looked at the actual code
yet though.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)