linux-kernel - RE: [alsa-devel] [PATCH 01/10] ASoC: core: Add snd_soc_dai_set_tdm_slot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6991b4aaf2a34f8180b24f7a2ae8355a@BY2PR03MB505.namprd03.prod.outlook.com>
Date:	Wed, 5 Mar 2014 03:55:50 +0000
From:	"Li.Xiubo@...escale.com" <Li.Xiubo@...escale.com>
To:	Mark Brown <broonie@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>
CC:	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"Fabio.Estevam@...escale.com" <Fabio.Estevam@...escale.com>,
	"moinejf@...e.fr" <moinejf@...e.fr>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"kuninori.morimoto.gx@...esas.com" <kuninori.morimoto.gx@...esas.com>,
	"tiwai@...e.de" <tiwai@...e.de>,
	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
	"timur@...i.org" <timur@...i.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"denis@...rea.com" <denis@...rea.com>,
	"guangyu.chen@...escale.com" <guangyu.chen@...escale.com>,
	"mpa@...gutronix.de" <mpa@...gutronix.de>,
	"shawn.guo@...aro.org" <shawn.guo@...aro.org>
Subject: RE: [alsa-devel] [PATCH 01/10] ASoC: core: Add
 snd_soc_dai_set_tdm_slot_xlate().


> Subject: Re: [alsa-devel] [PATCH 01/10] ASoC: core: Add
> snd_soc_dai_set_tdm_slot_xlate().
> 
> On Sat, Mar 01, 2014 at 02:19:44PM +0100, Lars-Peter Clausen wrote:
> 
> > I'm not quite sure I fully understand what this patch is trying to
> > solve. It adds a variant snd_soc_dai_set_tdm_slot() that instead of
> > taking a rx and tx mask calculates the masks based on the number of
> > slots? In that case I don't really see how the xlate in the name
> > relates to that. xlate is something you'd typically expect in a
> > devicetree context. Maybe one should be called
> > snd_soc_dai_set_tdm_slot() and the other
> > snd_soc_dai_set_tdm_slot_and_masks()?
> 
> > But another question is do we really need this? I don't see the
> > problem that is solved by this patchset.
> 
> My understanding is that the patch set aims to provide a way of using
> the TDM features of drivers from DT, providing a standardised format for
> expressing the TDM setup in the DT.  I've not looked at the actual code
> yet though.

@Lars,

Sorry for late, many mails had been discard by my outlook, including the
Last one.

@Mark, @Lars,

This adds the function of snd_soc_dai_set_tdm_slot_xlate, which is almost
One new signature of snd_soc_dai_set_tdm_slot discarding the mask
Parameters, which could be generated by itself.

And I want to provide one standard method for the drivers who are parsing
The TDM information from the DT node. 


Thanks,

--
Best Regards,
Xiubo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/