linux-kernel - Re: [alsa-devel] [PATCH 01/10] ASoC: core: Add snd_soc_dai_set_tdm_slot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140305063015.GA1704@sirena.org.uk>
Date:	Wed, 5 Mar 2014 14:30:15 +0800
From:	Mark Brown <broonie@...nel.org>
To:	"Li.Xiubo@...escale.com" <Li.Xiubo@...escale.com>
Cc:	Lars-Peter Clausen <lars@...afoo.de>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"Fabio.Estevam@...escale.com" <Fabio.Estevam@...escale.com>,
	"moinejf@...e.fr" <moinejf@...e.fr>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"kuninori.morimoto.gx@...esas.com" <kuninori.morimoto.gx@...esas.com>,
	"tiwai@...e.de" <tiwai@...e.de>,
	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
	"timur@...i.org" <timur@...i.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"denis@...rea.com" <denis@...rea.com>,
	"guangyu.chen@...escale.com" <guangyu.chen@...escale.com>,
	"mpa@...gutronix.de" <mpa@...gutronix.de>,
	"shawn.guo@...aro.org" <shawn.guo@...aro.org>
Subject: Re: [alsa-devel] [PATCH 01/10] ASoC: core: Add
 snd_soc_dai_set_tdm_slot_xlate().

On Wed, Mar 05, 2014 at 03:55:50AM +0000, Li.Xiubo@...escale.com wrote:

> This adds the function of snd_soc_dai_set_tdm_slot_xlate, which is almost
> One new signature of snd_soc_dai_set_tdm_slot discarding the mask
> Parameters, which could be generated by itself.

Right, so that's not a bad thing but the _xlate() naming is confusing -
Lars' point was that if a function is called _xlate() it would usually
be an operation used as part of DT parsing, not something called from
non-DT code.  The new interface is probably a good thing but needs a
different name (perhaps _simple or something?) or we need to rename the
old one out of the way (it's slightly less flexible so we probably don't
want to remove it totally).

> And I want to provide one standard method for the drivers who are parsing
> The TDM information from the DT node. 

This is a good goal.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)